github-actions[bot]
commented
1 year ago 📊 Tachometer Benchmark Results
Summary
benchmark-total
- emoji-picker-element-database-interactions: unsure 🔍 -3% - +5% (-3.55ms - +6.47ms)
this-change vs tip-of-tree - emoji-picker-element-first-load: unsure 🔍 -3% - +9% (-1.64ms - +5.40ms)
this-change vs tip-of-tree - emoji-picker-element-second-load: unsure 🔍 -9% - +4% (-5.28ms - +2.57ms)
this-change vs tip-of-tree
Results
emoji-picker-element-database-interactions
- Browser: chrome-headless 108.0.5359.98
- Sample size: 50
- Built by: Benchmarks #187
- Commit: 20984b1
| Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
|---|---|---|---|
| this-change | 139.27ms - 147.39ms | - | unsure 🔍 -3% - +5% -3.55ms - +6.47ms |
| tip-of-tree tip-of-tree | 138.94ms - 144.80ms | unsure 🔍 -4% - +2% -6.47ms - +3.55ms | - |
emoji-picker-element-first-load
- Browser: chrome-headless 108.0.5359.98
- Sample size: 90
- Built by: Benchmarks #187
- Commit: 20984b1
| Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
|---|---|---|---|
| this-change | 57.28ms - 62.43ms | - | unsure 🔍 -3% - +9% -1.64ms - +5.40ms |
| tip-of-tree tip-of-tree | 55.57ms - 60.38ms | unsure 🔍 -9% - +3% -5.40ms - +1.64ms | - |
emoji-picker-element-second-load
- Browser: chrome-headless 108.0.5359.98
- Sample size: 80
- Built by: Benchmarks #187
- Commit: 20984b1
| Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
|---|---|---|---|
| this-change | 56.16ms - 61.72ms | - | unsure 🔍 -9% - +4% -5.28ms - +2.57ms |
| tip-of-tree tip-of-tree | 57.53ms - 63.06ms | unsure 🔍 -4% - +9% -2.57ms - +5.28ms | - |
nolanlawson
Avoids some memory churn by not recreating empty objects and arrays in several places.
This introduces some risk in that we might leak these objects outside of the picker/database, and if people mutate them, then they could change the behavior. But people might already have a bad time if they mutate the objects returned from the database/picker – it's not something I've tested in the past.