Closed nolanlawson closed 1 year ago
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 175.89ms - 185.32ms | - | unsure 🔍 -4% - +4% -8.13ms - +6.41ms |
tip-of-tree tip-of-tree | 175.93ms - 187.00ms | unsure 🔍 -4% - +5% -6.41ms - +8.13ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 67.07ms - 74.98ms | - | unsure 🔍 -6% - +9% -4.43ms - +6.48ms |
tip-of-tree tip-of-tree | 66.24ms - 73.76ms | unsure 🔍 -9% - +6% -6.48ms - +4.43ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 72.45ms - 79.40ms | - | unsure 🔍 -9% - +4% -6.91ms - +3.09ms |
tip-of-tree tip-of-tree | 74.24ms - 81.43ms | unsure 🔍 -4% - +9% -3.09ms - +6.91ms | - |
Size Change: +76 B (0%)
Total Size: 42.4 kB
Filename | Size | Change |
---|---|---|
./bundle.js |
42.4 kB | +76 B (0%) |
Interestingly not all state can be saved, but this is mostly a browser problem. E.g. if the skintone picker is expanded, then remove+append will collapse it, because the blur
event fires. And scroll state is also not restored.
But everything else is restored and seems to work well after document.body.removeChild(picker); document.body.appendChild(picker)
. So this seems like a decent change.
Fixes #312