github-actions[bot]
commented
1 year ago 📊 Tachometer Benchmark Results
Summary
benchmark-total
- emoji-picker-element-database-interactions: unsure 🔍 -5% - +3% (-6.60ms - +4.33ms)
this-change vs tip-of-tree - emoji-picker-element-first-load: unsure 🔍 -8% - +3% (-4.75ms - +1.74ms)
this-change vs tip-of-tree - emoji-picker-element-second-load: unsure 🔍 -8% - +4% (-4.70ms - +2.01ms)
this-change vs tip-of-tree
Results
emoji-picker-element-database-interactions
- Browser: chrome-headless 113.0.5672.126
- Sample size: 50
- Built by: Benchmarks #229
- Commit: e14bf04
| Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
|---|---|---|---|
| this-change | 127.42ms - 135.06ms | - | unsure 🔍 -5% - +3% -6.60ms - +4.33ms |
| tip-of-tree tip-of-tree | 128.47ms - 136.29ms | unsure 🔍 -3% - +5% -4.33ms - +6.60ms | - |
emoji-picker-element-first-load
- Browser: chrome-headless 113.0.5672.126
- Sample size: 90
- Built by: Benchmarks #229
- Commit: e14bf04
| Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
|---|---|---|---|
| this-change | 52.43ms - 56.84ms | - | unsure 🔍 -8% - +3% -4.75ms - +1.74ms |
| tip-of-tree tip-of-tree | 53.77ms - 58.51ms | unsure 🔍 -3% - +9% -1.74ms - +4.75ms | - |
emoji-picker-element-second-load
- Browser: chrome-headless 113.0.5672.126
- Sample size: 100
- Built by: Benchmarks #229
- Commit: e14bf04
| Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
|---|---|---|---|
| this-change | 51.44ms - 56.00ms | - | unsure 🔍 -8% - +4% -4.70ms - +2.01ms |
| tip-of-tree tip-of-tree | 52.60ms - 57.52ms | unsure 🔍 -4% - +9% -2.01ms - +4.70ms | - |
Fixes #335
After upgrading Svelte, I noticed a new accessibility warning about how
activedescendantelements should havetabindex. I looked into it, and decided I could simplify the skintone picker by abiding by this rule.Tested in various screenreaders/browsers, the behavior is the same as before, but I was able to clean up the code a bit and get rid of the warning. I also went ahead and fixed #335 because I noticed it.