Closed nolanlawson closed 1 year ago
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 127.42ms - 135.06ms | - | unsure 🔍 -5% - +3% -6.60ms - +4.33ms |
tip-of-tree tip-of-tree | 128.47ms - 136.29ms | unsure 🔍 -3% - +5% -4.33ms - +6.60ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 52.43ms - 56.84ms | - | unsure 🔍 -8% - +3% -4.75ms - +1.74ms |
tip-of-tree tip-of-tree | 53.77ms - 58.51ms | unsure 🔍 -3% - +9% -1.74ms - +4.75ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 51.44ms - 56.00ms | - | unsure 🔍 -8% - +4% -4.70ms - +2.01ms |
tip-of-tree tip-of-tree | 52.60ms - 57.52ms | unsure 🔍 -4% - +9% -2.01ms - +4.70ms | - |
Size Change: -27 B (0%)
Total Size: 42.6 kB
Filename | Size | Change |
---|---|---|
./bundle.js |
42.6 kB | -27 B (0%) |
Fixes #335
After upgrading Svelte, I noticed a new accessibility warning about how
activedescendant
elements should havetabindex
. I looked into it, and decided I could simplify the skintone picker by abiding by this rule.Tested in various screenreaders/browsers, the behavior is the same as before, but I was able to clean up the code a bit and get rid of the warning. I also went ahead and fixed #335 because I noticed it.