Closed nolanlawson closed 11 months ago
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 132.36ms - 140.82ms | - | unsure 🔍 -2% - +6% -2.38ms - +8.27ms |
tip-of-tree tip-of-tree | 130.41ms - 136.88ms | unsure 🔍 -6% - +2% -8.27ms - +2.38ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 54.58ms - 60.25ms | - | unsure 🔍 -9% - +6% -5.00ms - +3.30ms |
tip-of-tree tip-of-tree | 55.24ms - 61.30ms | unsure 🔍 -6% - +9% -3.30ms - +5.00ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 54.37ms - 59.63ms | - | unsure 🔍 -9% - +3% -5.49ms - +1.86ms |
tip-of-tree tip-of-tree | 56.24ms - 61.39ms | unsure 🔍 -3% - +10% -1.86ms - +5.49ms | - |
Size Change: +86 B (0%)
Total Size: 42.8 kB
Filename | Size | Change |
---|---|---|
./bundle.js |
42.8 kB | +86 B (0%) |
Fixes #366
The
title
now comes from theannotation
(if available - custom emoji may not have these). If not, it falls back to the shortcodes separated by a comma.I also added the
annotation
to thearia-label
because it seems like a nice enhancement – the annotation is often a better description than the shortcodes.I don't see a reason to remove the shortcodes from the
aria-label
– it's just additional information, and the screenreader user can tab to the next emoji if they don't want to hear the shortcodes listed.One downside of this is that there is no way for a sighted mouse user to figure out the shortcodes, but this is not vital to me since sighted mobile users were never able to see the
title
anyway.