feat: upgrade to svelte 4

nolanlawson commented 10 months ago

~BREAKING CHANGE: users of the svelte.js asset will need to be using svelte v4+~

Edit: no longer a breaking change because I'm adding a shim for Svelte v3

github-actions[bot] commented 10 months ago

📊 Tachometer Benchmark Results

emoji-picker-element-database-interactions: unsure 🔍 -3% - +3% (-3.80ms - +4.48ms)
^{this-change vs tip-of-tree}
emoji-picker-element-first-load: unsure 🔍 -2% - +4% (-1.05ms - +2.54ms)
^{this-change vs tip-of-tree}
emoji-picker-element-second-load: unsure 🔍 -6% - +7% (-3.23ms - +3.78ms)
^{this-change vs tip-of-tree}

emoji-picker-element-database-interactions

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	129.59ms - 135.51ms	-	unsure 🔍 -3% - +3% -3.80ms - +4.48ms
tip-of-tree tip-of-tree	129.32ms - 135.10ms	unsure 🔍 -3% - +3% -4.48ms - +3.80ms	-

emoji-picker-element-first-load

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	56.83ms - 59.23ms	-	unsure 🔍 -2% - +4% -1.05ms - +2.54ms
tip-of-tree tip-of-tree	55.95ms - 58.62ms	unsure 🔍 -4% - +2% -2.54ms - +1.05ms	-

emoji-picker-element-second-load

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree
this-change	49.06ms - 53.84ms	-	unsure 🔍 -6% - +7% -3.23ms - +3.78ms
tip-of-tree tip-of-tree	48.61ms - 53.74ms	unsure 🔍 -7% - +6% -3.78ms - +3.23ms	-

nolanlawson commented 10 months ago

Svelte 4 is required due to the new ensure_array_like API that is being used.

Could potentially avoid the breaking change by just injecting this in ourselves.

github-actions[bot] commented 10 months ago

Size Change: -85 B (0%)

Total Size: 42.7 kB

Filename	Size	Change
`./bundle.js`	42.7 kB	-85 B (0%)