nolanlawson / emoji-picker-element

A lightweight emoji picker for the modern web
https://nolanlawson.github.io/emoji-picker-element/
Apache License 2.0
1.27k stars 80 forks source link

fix: avoid newer JS syntax to support old Safari #380

Closed nolanlawson closed 8 months ago

nolanlawson commented 8 months ago

Fixes #379

Avoids breaking old browsers by avoiding the optional chaining (?.) syntax.

github-actions[bot] commented 8 months ago

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-database-interactions: unsure 🔍 -2% - +2% (-2.11ms - +2.22ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -3% - +4% (-1.33ms - +1.80ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +3% (-1.95ms - +1.23ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-database-interactions
  • Browser: chrome-headless 119.0.6045.159
  • Sample size: 50
  • Built by: Benchmarks #295
  • Commit: 4b9a348
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
89.21ms - 92.13ms-unsure 🔍
-2% - +2%
-2.11ms - +2.22ms
tip-of-tree
tip-of-tree
89.02ms - 92.21msunsure 🔍
-2% - +2%
-2.22ms - +2.11ms
-
emoji-picker-element-first-load
  • Browser: chrome-headless 119.0.6045.159
  • Sample size: 50
  • Built by: Benchmarks #295
  • Commit: 4b9a348
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
41.90ms - 44.25ms-unsure 🔍
-3% - +4%
-1.33ms - +1.80ms
tip-of-tree
tip-of-tree
41.81ms - 43.87msunsure 🔍
-4% - +3%
-1.80ms - +1.33ms
-
emoji-picker-element-second-load
  • Browser: chrome-headless 119.0.6045.159
  • Sample size: 50
  • Built by: Benchmarks #295
  • Commit: 4b9a348
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
40.14ms - 42.24ms-unsure 🔍
-5% - +3%
-1.95ms - +1.23ms
tip-of-tree
tip-of-tree
40.35ms - 42.74msunsure 🔍
-3% - +5%
-1.23ms - +1.95ms
-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] commented 8 months ago

Size Change: -21 B (0%)

Total Size: 42.8 kB

Filename Size Change
./bundle.js 42.8 kB -21 B (0%)

compressed-size-action

nolanlawson commented 8 months ago

Oops, forgot this was only added for the svelte.js build... need something else to actually fix #379.