search

nolanlawson / emoji-picker-element

A lightweight emoji picker for the modern web
https://nolanlawson.github.io/emoji-picker-element/
Apache License 2.0
1.27k stars 80 forks source link

feat: add support for emoji v15.1 #383

Closed nolanlawson closed 7 months ago

nolanlawson commented 7 months ago

Adds support for emoji v15.1 with 🐦‍🔥 (phoenix) and 🙂‍↔️ (shaking head) among others.

See also https://github.com/nolanlawson/emoji-picker-element-data/pull/8

github-actions[bot] commented 7 months ago

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +5% (-3.71ms - +5.15ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -2% - +5% (-1.01ms - +2.28ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +3% (-1.91ms - +1.13ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-database-interactions
  • Browser: chrome-headless 119.0.6045.159
  • Sample size: 50
  • Built by: Benchmarks #310
  • Commit: fff1a77
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
93.73ms - 99.95ms-unsure 🔍
-4% - +5%
-3.71ms - +5.15ms
tip-of-tree
tip-of-tree		92.97ms - 99.27msunsure 🔍
-5% - +4%
-5.15ms - +3.71ms		-
emoji-picker-element-first-load
  • Browser: chrome-headless 119.0.6045.159
  • Sample size: 50
  • Built by: Benchmarks #310
  • Commit: fff1a77
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
42.33ms - 44.79ms-unsure 🔍
-2% - +5%
-1.01ms - +2.28ms
tip-of-tree
tip-of-tree		41.83ms - 44.02msunsure 🔍
-5% - +2%
-2.28ms - +1.01ms		-
emoji-picker-element-second-load
  • Browser: chrome-headless 119.0.6045.159
  • Sample size: 50
  • Built by: Benchmarks #310
  • Commit: fff1a77
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
37.81ms - 39.88ms-unsure 🔍
-5% - +3%
-1.91ms - +1.13ms
tip-of-tree
tip-of-tree		38.12ms - 40.35msunsure 🔍
-3% - +5%
-1.13ms - +1.91ms		-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] commented 7 months ago

Size Change: +2 B (0%)

Total Size: 42.8 kB

Filename Size Change
./bundle.js 42.8 kB +2 B (0%)

compressed-size-action

nolanlawson commented 7 months ago

Looks like emojibase-data decided to add the variation selector to a few more emojis... This might technically be a breaking change in certain cases (e.g. see my own broken tests), but I don't think it's deserving of a 2.0.0 release because we can't really do a breaking change release every time the emoji data changes slightly. Adding the variation selector will probably make the character just appear more consistently in more environments anyway.