nolanlawson / emoji-picker-element

A lightweight emoji picker for the modern web
https://nolanlawson.github.io/emoji-picker-element/
Apache License 2.0
1.27k stars 80 forks source link

fix: avoid HTML comments, simplify replacement logic #409

Closed nolanlawson closed 4 months ago

nolanlawson commented 4 months ago

Experimental version of the framework where we use text nodes instead of HTML comments. Also attempting to simplify the implementation a bit.

github-actions[bot] commented 4 months ago

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -3% - +1% (-0.88ms - +0.20ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +7% (-3.89ms - +6.80ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -4% - +3% (-1.84ms - +1.74ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -8% - +3% (-3.08ms - +1.09ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
  • Browser: chrome-headless 122.0.6261.128
  • Sample size: 50
  • Built by: Benchmarks #407
  • Commit: 6e4780f
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.31ms - 33.52ms-unsure 🔍
-3% - +1%
-0.88ms - +0.20ms
tip-of-tree
tip-of-tree
33.23ms - 34.29msunsure 🔍
-1% - +3%
-0.20ms - +0.88ms
-
emoji-picker-element-database-interactions
  • Browser: chrome-headless 122.0.6261.128
  • Sample size: 50
  • Built by: Benchmarks #407
  • Commit: 6e4780f
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
99.56ms - 107.40ms-unsure 🔍
-4% - +7%
-3.89ms - +6.80ms
tip-of-tree
tip-of-tree
98.39ms - 105.65msunsure 🔍
-7% - +4%
-6.80ms - +3.89ms
-
emoji-picker-element-first-load
  • Browser: chrome-headless 122.0.6261.128
  • Sample size: 50
  • Built by: Benchmarks #407
  • Commit: 6e4780f
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
50.32ms - 52.81ms-unsure 🔍
-4% - +3%
-1.84ms - +1.74ms
tip-of-tree
tip-of-tree
50.32ms - 52.90msunsure 🔍
-3% - +4%
-1.74ms - +1.84ms
-
emoji-picker-element-second-load
  • Browser: chrome-headless 122.0.6261.128
  • Sample size: 50
  • Built by: Benchmarks #407
  • Commit: 6e4780f
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.79ms - 37.86ms-unsure 🔍
-8% - +3%
-3.08ms - +1.09ms
tip-of-tree
tip-of-tree
35.91ms - 38.72msunsure 🔍
-3% - +9%
-1.09ms - +3.08ms
-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] commented 4 months ago

Size Change: -226 B (-1%)

Total Size: 36.4 kB

Filename Size Change
./bundle.js 36.4 kB -226 B (-1%)

compressed-size-action