Closed nolanlawson closed 3 months ago
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 33.33ms - 33.63ms | - | unsure 🔍 -1% - +1% -0.17ms - +0.21ms |
tip-of-tree tip-of-tree | 33.35ms - 33.58ms | unsure 🔍 -1% - +1% -0.21ms - +0.17ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 96.89ms - 104.23ms | - | unsure 🔍 -7% - +4% -6.87ms - +3.79ms |
tip-of-tree tip-of-tree | 98.23ms - 105.97ms | unsure 🔍 -4% - +7% -3.79ms - +6.87ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 50.38ms - 53.53ms | - | unsure 🔍 -5% - +4% -2.38ms - +1.92ms |
tip-of-tree tip-of-tree | 50.72ms - 53.65ms | unsure 🔍 -4% - +5% -1.92ms - +2.38ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 50.00ms - 50.06ms | - | unsure 🔍 -0% - +0% -0.05ms - +0.06ms |
tip-of-tree tip-of-tree | 49.98ms - 50.06ms | unsure 🔍 -0% - +0% -0.06ms - +0.05ms | - |
Version | Avg time | vs this-change | vs tip-of-tree tip-of-tree |
---|---|---|---|
this-change | 34.90ms - 37.89ms | - | unsure 🔍 -7% - +4% -2.80ms - +1.40ms |
tip-of-tree tip-of-tree | 35.62ms - 38.57ms | unsure 🔍 -4% - +8% -1.40ms - +2.80ms | - |
Size Change: +420 B (+1%)
Total Size: 37.1 kB
Filename | Size | Change |
---|---|---|
./bundle.js |
37.1 kB | +420 B (+1%) |
I'm not sure I can actually get this to work properly. It's so much added complexity, and it still doesn't really improve the perf by doing what I'd really like to do, which is fire off the initial HTTP request before rendering.
It's a nice idea, but it's probably too complex to implement.
If
database.close()
is called, we should cancel any inflight IDB/fetch operations. This should eventually allow us to start setting up the database sooner than a microtask, since we can cancel the request if the user decides to change the data source.