nolanlawson / emoji-picker-element

A lightweight emoji picker for the modern web
https://nolanlawson.github.io/emoji-picker-element/
Apache License 2.0
1.27k stars 80 forks source link

test: add test to ensure that node is defined #419

Closed nolanlawson closed 3 months ago

nolanlawson commented 3 months ago

418 makes me a bit nervous but I can't seem to find any case in the Vitest tests at least where the node would be undefined... this adds a check to prove it.

github-actions[bot] commented 3 months ago

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -0% - +1% (-0.07ms - +0.25ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +5% (-4.72ms - +4.83ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -5% - +4% (-2.72ms - +2.12ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: slower ❌ 0% - 9% (0.21ms - 3.38ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
  • Browser: chrome-headless 123.0.6312.105
  • Sample size: 50
  • Built by: Benchmarks #426
  • Commit: 4c577ab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.30ms - 33.55ms-unsure 🔍
-0% - +1%
-0.07ms - +0.25ms
tip-of-tree
tip-of-tree
33.24ms - 33.43msunsure 🔍
-1% - +0%
-0.25ms - +0.07ms
-
emoji-picker-element-database-interactions
  • Browser: chrome-headless 123.0.6312.105
  • Sample size: 50
  • Built by: Benchmarks #426
  • Commit: 4c577ab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
102.44ms - 109.53ms-unsure 🔍
-4% - +5%
-4.72ms - +4.83ms
tip-of-tree
tip-of-tree
102.74ms - 109.12msunsure 🔍
-5% - +4%
-4.83ms - +4.72ms
-
emoji-picker-element-first-load
  • Browser: chrome-headless 123.0.6312.105
  • Sample size: 50
  • Built by: Benchmarks #426
  • Commit: 4c577ab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
50.59ms - 53.99ms-unsure 🔍
-5% - +4%
-2.72ms - +2.12ms
tip-of-tree
tip-of-tree
50.87ms - 54.31msunsure 🔍
-4% - +5%
-2.12ms - +2.72ms
-
emoji-picker-element-second-load
  • Browser: chrome-headless 123.0.6312.105
  • Sample size: 80
  • Built by: Benchmarks #426
  • Commit: 4c577ab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
37.15ms - 39.15ms-slower ❌
0% - 9%
0.21ms - 3.38ms
tip-of-tree
tip-of-tree
35.12ms - 37.59msfaster ✔
1% - 9%
0.21ms - 3.38ms
-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] commented 3 months ago

Size Change: 0 B

Total Size: 36.4 kB

ℹī¸ View Unchanged | Filename | Size | | :--- | :---: | | `./bundle.js` | 36.4 kB |

compressed-size-action