nolanlawson / emoji-picker-element

A lightweight emoji picker for the modern web
https://nolanlawson.github.io/emoji-picker-element/
Apache License 2.0
1.49k stars 85 forks source link

chore: fix tachometer package swapping #439

Closed nolanlawson closed 2 months ago

nolanlawson commented 2 months ago

it looks like I've been using Tachometer incorrectly for some time, and wasn't actually comparing PRs against the master branch. :sweat_smile:

Due to https://github.com/google/tachometer/issues/215 I need to make sure that any time we import the Picker/Database from a benchmark script, we do so from an npm package name that Tachometer can swap out. Luckily we can just create a dummy file:. dependency to do exactly this.

Without this PR, the local and "remote" versions of Tachometer are both the same – just the local code!

github-actions[bot] commented 2 months ago

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -0% - +3% (-0.05ms - +1.07ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -5% - +4% (-5.61ms - +4.80ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -6% - +1% (-3.06ms - +0.52ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +3% (-2.18ms - +1.55ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
  • Browser: chrome-headless 127.0.6533.99
  • Sample size: 50
  • Built by: Benchmarks #463
  • Commit: 7644706
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
34.31ms - 35.16ms-unsure 🔍
-0% - +3%
-0.05ms - +1.07ms
tip-of-tree
tip-of-tree
33.86ms - 34.58msunsure 🔍
-3% - +0%
-1.07ms - +0.05ms
-
emoji-picker-element-database-interactions
  • Browser: chrome-headless 127.0.6533.99
  • Sample size: 50
  • Built by: Benchmarks #463
  • Commit: 7644706
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
102.81ms - 110.23ms-unsure 🔍
-5% - +4%
-5.61ms - +4.80ms
tip-of-tree
tip-of-tree
103.27ms - 110.58msunsure 🔍
-5% - +5%
-4.80ms - +5.61ms
-
emoji-picker-element-first-load
  • Browser: chrome-headless 127.0.6533.99
  • Sample size: 50
  • Built by: Benchmarks #463
  • Commit: 7644706
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
51.45ms - 53.61ms-unsure 🔍
-6% - +1%
-3.06ms - +0.52ms
tip-of-tree
tip-of-tree
52.38ms - 55.23msunsure 🔍
-1% - +6%
-0.52ms - +3.06ms
-
emoji-picker-element-second-load
  • Browser: chrome-headless 127.0.6533.99
  • Sample size: 50
  • Built by: Benchmarks #463
  • Commit: 7644706
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
45.26ms - 47.78ms-unsure 🔍
-5% - +3%
-2.18ms - +1.55ms
tip-of-tree
tip-of-tree
45.46ms - 48.20msunsure 🔍
-3% - +5%
-1.55ms - +2.18ms
-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] commented 2 months ago

Size Change: 0 B

Total Size: 36.3 kB

ℹī¸ View Unchanged | Filename | Size | | :--- | :---: | | `./bundle.js` | 36.3 kB |

compressed-size-action