nolanlawson / emoji-picker-element

A lightweight emoji picker for the modern web
https://nolanlawson.github.io/emoji-picker-element/
Apache License 2.0
1.49k stars 85 forks source link

perf: avoid recalculating custom emoji index #446

Closed nolanlawson closed 1 month ago

nolanlawson commented 1 month ago

This won't show up in the benchmarks, but we do an extra recalculation of the custom emoji search index that we don't need to.

github-actions[bot] commented 1 month ago

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -3% - +4% (-0.92ms - +1.53ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -7% - +3% (-8.48ms - +3.67ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -4% - +5% (-2.37ms - +2.85ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -4% - +3% (-1.69ms - +1.38ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
  • Browser: chrome-headless 128.0.0.0
  • Sample size: 50
  • Built by: Benchmarks #471
  • Commit: 985d225
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.60ms - 35.42ms-unsure 🔍
-3% - +4%
-0.92ms - +1.53ms
tip-of-tree
tip-of-tree
33.39ms - 35.03msunsure 🔍
-4% - +3%
-1.53ms - +0.92ms
-
emoji-picker-element-database-interactions
  • Browser: chrome-headless 128.0.0.0
  • Sample size: 50
  • Built by: Benchmarks #471
  • Commit: 985d225
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
107.42ms - 115.55ms-unsure 🔍
-7% - +3%
-8.48ms - +3.67ms
tip-of-tree
tip-of-tree
109.37ms - 118.41msunsure 🔍
-3% - +8%
-3.67ms - +8.48ms
-
emoji-picker-element-first-load
  • Browser: chrome-headless 128.0.0.0
  • Sample size: 50
  • Built by: Benchmarks #471
  • Commit: 985d225
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
51.32ms - 54.98ms-unsure 🔍
-4% - +5%
-2.37ms - +2.85ms
tip-of-tree
tip-of-tree
51.05ms - 54.77msunsure 🔍
-5% - +4%
-2.85ms - +2.37ms
-
emoji-picker-element-second-load
  • Browser: chrome-headless 128.0.0.0
  • Sample size: 50
  • Built by: Benchmarks #471
  • Commit: 985d225
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
42.84ms - 44.89ms-unsure 🔍
-4% - +3%
-1.69ms - +1.38ms
tip-of-tree
tip-of-tree
42.88ms - 45.16msunsure 🔍
-3% - +4%
-1.38ms - +1.69ms
-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] commented 1 month ago

Size Change: +38 B (+0.1%)

Total Size: 36.4 kB

Filename Size Change
./bundle.js 36.4 kB +38 B (+0.1%)

compressed-size-action