search

nolanlawson / html5workertest

Show which APIs are supported in Web Workers and Service Workers (UNMAINTAINED)
https://nolanlawson.github.io/html5workertest/
Apache License 2.0
53 stars 6 forks source link

Support Sauce Labs on PRs #15

Closed halkeye closed 8 years ago

halkeye commented 8 years ago

@nolanlawson I couldn't figure out your sauce_username so I just put a placeholder for now.

this should work for pull requests though if you are okay with exposing that info (though I suspect the branch-only-master will prevent prs too?)

halkeye commented 8 years ago

oh wow, it totally still runs for PRs

yea, if we can get the username in there, it should test every PR

nolanlawson commented 8 years ago

I need to take a second look at this and get everything working. Putting it on my TODO list, thanks for the PR!

halkeye commented 8 years ago

<3

the only thing that i think needs changing is:

SAUCE_USERNAME=yourusername

nolanlawson commented 8 years ago

On second thought, I would prefer not to merge this because the current behavior is that every run against SauceLabs also writes the results to my personal Cloudant database, and I'd rather not allow random people to be able to append to it, because currently I don't have a way to remove data; it only grows over time. So thanks a bunch for the PR; I'll probably use it on other projects but for this one the current behavior is okay.

halkeye commented 8 years ago

In the PR mode, the cloudant's won't be defined, so it won't actually write to your db

but yea, thats cool too man :D

On Sun, Nov 20, 2016 at 11:41 AM, Nolan Lawson notifications@github.com wrote:

Closed #15 https://github.com/nolanlawson/html5workertest/pull/15.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nolanlawson/html5workertest/pull/15#event-865699165, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGuBwC6KsFYQVnk9ewaryHGKERUXwkAks5rAKKHgaJpZM4Kc28c .