search

nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)
https://pinafore.social
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

feat: Add "a" keyboard shortcut to bookmark a toot. #2268

Closed jcsteh closed 1 year ago

jcsteh commented 1 year ago

Fixes #2237.

nolanlawson commented 1 year ago

Awesome, thank you! I just added one small thing: help text (for when you press the ? key) and an aria live announcement of "bookmarked" or "unbookmarked."

jcsteh commented 1 year ago

Note that when the toast appears, the alert will get read already, so I'm not sure the live region announcement is necessary.

jcsteh commented 1 year ago

Sorry I forgot to update the help text. That was a silly oversight.

nolanlawson commented 1 year ago

Ah yes, I forgot about the alert. The alert is actually preferable to the aria live region, so that sighted people get the feedback as well.

jcsteh commented 1 year ago

In that case, are you happy for me to revert your live region change? The alert already gets displayed with my original code.

nolanlawson commented 1 year ago

No worries, I reverted it. Now it just has the shortcut help text I added. Thanks a lot!