search

nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)
https://pinafore.social
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

Translation into Spanish #2281

Closed nvdaes closed 1 year ago

nolanlawson commented 1 year ago

Thanks a lot! Just so you're aware, translations do not really work yet, unless you're willing to host Pinafore yourself: https://github.com/nolanlawson/pinafore/blob/master/docs/Internationalization.md

nvdaes commented 1 year ago

Thanks for your interest. The translation may take some time. If I cannot host Pinafore, maybe done by others or you may request help to host different languages, for example with donations. Let's see how thingsgo.

nolanlawson commented 1 year ago

Totally understandable. To be honest, I have not had the time to do translations properly, which is why it's in the state it's in. I just wanted to let you know before you put in a bunch of effort to translate the whole thing. :slightly_smiling_face:

nvdaes commented 1 year ago

I've finished this. If something needs to be improved, I'll try to do it when I use this seeing the whole context in real life, though I've read the comments of the different sections and they are helpful. We'll need to remove some strings when PR #2300 is merged.

nolanlawson commented 1 year ago

Awesome, thanks! I don't know when/if we'll get internationalization actually working in Pinafore, but I appreciate the effort. :slightly_smiling_face:

nvdaes commented 1 year ago

A person mentioned that may host Pinafores translated into Spanish in a server. I know that emojis aren"t translated, but for now this is my work. BTW, for me is more accessible to use Pinafore"s emojis picker than the emojis panel on Windows while using Pinafore, with Nvda screen reader. Thank you.

Enviado desde mi iPhone

El 11 dic 2022, a las 0:24, Nolan Lawson @.***> escribió:

 Awesome, thanks! I don't know when/if we'll get internationalization actually working in Pinafore, but I appreciate the effort. 🙂

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

nolanlawson commented 1 year ago

Emojis are actually translated, emoji-picker-element supports it: https://github.com/nolanlawson/emoji-picker-element/#internationalization

I can't recall if Pinafore correctly hooks into this functionality though.

nolanlawson commented 1 year ago

Did not mean to close.

nvdaes commented 1 year ago

Ok, I think that emojis can be translated but that they aren"t translated yet. Thanks.

Enviado desde mi iPhone

El 11 dic 2022, a las 0:42, Nolan Lawson @.***> escribió:

 Emojis are actually translated, emoji-picker-element supports it: https://github.com/nolanlawson/emoji-picker-element/#internationalization

I can't recall if Pinafore correctly hooks into this functionality though.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

nvdaes commented 1 year ago

Meant I thought emojis need to be translated. Just a spanish speaker typing fast and using present instead of past in a verb.

nolanlawson commented 1 year ago

Yes, this applies to the title/aria-label on emojis too. We get them from emoji-picker-element's database.

nvdaes commented 1 year ago

Ok, if this is merged and hosted, I"ll see if translation of emojis works as expected. I did the translation on Windows without runing the linter, since I didn"t edit the file on WSL.

Enviado desde mi iPhone

El 11 dic 2022, a las 1:03, Nolan Lawson @.***> escribió:

 Yes, this applies to the title/aria-label on emojis too. We get them from emoji-picker-element's database.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

nvdaes commented 1 year ago

I've fixed errors and translated new messages included in /src/intl/en-US.js Now all checks pass. @nolanlawson , if you want, we can wait to see if more messages have to be translated for the next release and then you may merge this. We're talking in a spanish mailing list about the possibility to host bPinafore in Spanish and we'll be testing this translation locally in dev mode.

nolanlawson commented 1 year ago

Here, this fixes the Spanish locale for the emoji picker: e335441d

I'm happy to merge this, please feel free to host your own Spanish version of Pinafore. Thanks for the effort!

nvdaes commented 1 year ago

Thank you. Feel free to merge this when you want. If I detect some to improve, I"ll do after the next release. We"ll thinking about host this in Spanish, maybe on GitHub Pages or Vercel, so Ill inform that this is approved to see if we register a domain for this.

Enviado desde mi iPhone

El 17 dic 2022, a las 18:11, Nolan Lawson @.***> escribió:

 @nolanlawson approved this pull request.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.