search

nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)
https://pinafore.social
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

If a pinned toot has a content warning, its impossible to read it with a screen reader. #2294

Closed TheQuinbox closed 1 year ago

TheQuinbox commented 1 year ago

STR:

  1. Open someone's profile with a pinned toot with a CW. In this case, I used mine (thequinbox@dragonscave.space).
  2. Press X to try and reveal what's behind the content warning.
  3. Attempt to read the toot using a screen reader. The text of the post is totally ignored.
nolanlawson commented 1 year ago

I looked into it, and there doesn't seem to be anything different about pinned toots compared to unpinned toots. When I press X on a pinned toot, it (visually) opens as it should. It also updates the aria-label on the <article> appropriately.

I think this is a duplicate of https://github.com/nolanlawson/pinafore/issues/2180. I.e. it's a screenreader issue. Closing for now, please reopen if I'm wrong!

TheQuinbox commented 1 year ago

Hi, This does appear to be different, yeah. It doesn't read, even after scrolling over it with J and K. Would an audio demo perhaps help to demonstrate what I mean?

nolanlawson commented 1 year ago

@TheQuinbox What screenreader, browser, and OS are you using? I inspected this in the DevTools, and the aria-label of the <article> is correctly being updated.

MarcoZehe commented 1 year ago

FWIW, when I view a profile which has pinned toots, the toot text isn't read by any of my screen readers in any browser, either. Might that be related? it says "Pinned toot", followed by the author and some other info, but not the text. I have never seen pinned toots with a CW yet, so cannot reproduce, or not reproduce, that, but the fact that normal pinned toots don't have the toot text in the article's aria label is definitely reproducible here.

TheQuinbox commented 1 year ago

Yup, that's the same issue I'm having. Although, with a content warning, the warning is read. However, when you press x, the exact same thing @marcozehe described happens.

I've tried this with VoiceOver in both Safari and Firefox, and NVDA in Firefox and Edge.

nolanlawson commented 1 year ago

Ah okay, somehow pinned toots are missing the aria-label I guess. That seems to be the bug.