search

nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)
https://pinafore.social
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

Fix rich push notifications for single-instance situations #2296

Closed tbroyer closed 1 year ago

nolanlawson commented 1 year ago

@tbroyer Thanks for opening this PR! Could you provide some more detail on what bug this fixes exactly? I don't use push notifications myself, so I'm not super familiar with this part of the code. Thanks!

nolanlawson commented 1 year ago

Ah I see, I missed https://github.com/nolanlawson/pinafore/issues/1663. I will study to see what is going on here.

nolanlawson commented 1 year ago

I'm confused about what's going on here and what this fixes. Maybe my brain is dead because it's Sunday morning, but I just don't get #1663 at all. https://github.com/nolanlawson/pinafore/issues/1663#issuecomment-1336510335