Closed samsapti closed 1 year ago
Thanks for the PR! I have zero knowledge about Docker, so bear with me. :slightly_smiling_face:
Questions:
@nolanlawson no problem at all! I'll try to answer your questions:
edge
image tag, which is the one created on every commit).docker-compose.yml
file to use the official image. Usually people use the README from GH on the Docker image page over on Docker Hub (I actually don't know whether that's a built-in feature on Docker Hub or not).Also, I forgot to mention, that it also builds the image on pull requests, but without pushing it to Docker Hub, so it's only for testing the build. Also, this only happens when the Dockerfile or the workflow file is edited.
Thanks for the details. It will probably take me quite some time to figure out enough about Docker to set up the account, put the proper instructions in the README, and make the proper modifications to the existing Dockerfile. I can't promise I'll get to this soon.
@nolanlawson you shouldn't need to modify the Dockerfile. You only need to make an account on Docker Hub, and then create a repo named pinafore
. Assuming you'll be using the same username as on GH, I've modified the docker-compose.yml
file for you.
I can also help out with the README if you want me too.
I came here to make this only to see that someone already did. Thanks @samsapti !
Added a GH Actions workflow to automatically publish Docker images with the following tags:
X.Y.Z
,X.Y
,X
)latest
tagedge
tag that follows the master branchCloses #2148. Regarding #1284, if you don't want to use Docker Hub, GHCR could be an alternative, since the project is already on GitHub. Having an official Docker image somewhere significantly eases self-hosting.