search

nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)
https://pinafore.social
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

Improve notifications page readability #2302

Closed NickColley closed 1 year ago

NickColley commented 1 year ago

Use lowest possible contrast gray that meets WCAG requirements for very deemphasised text.

Removes the status toolbar when its a notification for your own toot

Makes the notification page more readable without compromising access as much.

Closes https://github.com/nolanlawson/pinafore/issues/2249

Screenshots

Light

Before After
notifications page with hard to read text in toot notification notifications page with clearer text and no buttons in toot notification

Light

Before After
notifications page with hard to read text in toot notification notifications page with clearer text and no buttons in toot notification
NickColley commented 1 year ago

Think legit CI failure will update tests soon

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pinafore 🔄 Building (Inspect) Dec 17, 2022 at 0:41AM (UTC)
NickColley commented 1 year ago

Don't worry about the time to review, maybe I can help review and merge some stuff in future?

nolanlawson commented 1 year ago

You have committer access, so you should be able to, yeah. :)

I will need to hand off this project at some time anyway if I'm being honest with myself: https://nolanlawson.com/2022/11/22/thoughts-on-mastodon/

Next step is probably to create a GitHub org for it.

NickColley commented 1 year ago

Okay when I tried to get the tests running locally I accidentally upgraded my machine to the latest Ubuntu version and bricked it but now I've got a fresh install (that's how they get ya) so will hopefully finish this soon.

NickColley commented 1 year ago

@nolanlawson this is ready to merge once you're happy with it!

nolanlawson commented 1 year ago

I accidentally upgraded my machine to the latest Ubuntu version and bricked it

Sorry to hear about that. This is actually exactly why I finally learned to use Podman – it was too hard to get certain versions of Mastodon to work with my Ubuntu version.

FWIW, this is what I use:

podman run -dt -p 4002:4002 -p 3000:3000 -p 4000:4000 -p 10000:10000 -p 3035:3035 -v ~/workspace/pinafore:/mnt ubuntu:18.04

(Ubuntu 20.04 should also work.)

nolanlawson commented 1 year ago

LGTM, I had a couple nitpicks, but if you want to resolve them in this PR please go ahead, or else feel free to click the merge button and we can do it in another PR. Thanks!