search

nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)
https://pinafore.social
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

Pinafore is not just on localhost, but on all interfaces #2310

Open kescherCode opened 1 year ago

kescherCode commented 1 year ago

When starting the server for Pinafore using PORT=4002 node server.js, the server is in fact opened on all interfaces, not only localhost:4002.

nolanlawson commented 1 year ago

This would be a backwards-incompatible change. What is your use case for listening only on localhost? Would you be okay with an option to only listen on localhost?

kescherCode commented 1 year ago

I would've expected it not to listen on all interfaces, especially since for the Docker instruction in the README, it says it listens on localhost.

But yes, an option to only use localhost would be fine.

NickColley commented 1 year ago

@kescherCode can you give any more detail to what issue this causes you?

kescherCode commented 1 year ago

Since Pinafore is, from what I can tell, typically not supposed to be exposed on all interfaces, but rather behind a reverse proxy, it would make that port needlessly accessible whenever it's not firewalled off.