nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)
https://pinafore.social
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

Hotkeys help popup isn't easily scrollable #2332

Open joelanman opened 1 year ago

joelanman commented 1 year ago

First, thanks, really enjoying using Pinafore!

If I press ? the Hotkeys popup appears. However on my screen at 1536x960 it's cropped. The last thing I can see is 'm to mention author'. If I zoom at all (a common accessibility tool) the cropping gets worse.

Tested in Safari on MacOS

Update Just realised it's scrollable! However I see no scrollbars at all, and the scrollable area is not visible, which is why I didn't realise. I did try scrolling before but I clearly wasn't in the scrollable area

nolanlawson commented 1 year ago

It depends on the OS and browser. Some show the scrollbar, some don't.

I don't think we should forcefully try to always show a scrollbar; we should follow the browser/OS defaults. Sorry it's not obvious in this case, but I can't think of a good solution.

Note that in your MacOS settings, there is a setting for making the scrollbar always visible across the entire OS. :)

joelanman commented 1 year ago

Just a suggestion, but for me the issue was the scrollable area wasn't visible - here's what I mean:

hotkeys popup with a white border around the scrollable area

Obviously this could look nicer, but my point is I tried to scroll but because the scrollable area wasn't visible it didn't work. As there was no visible edge, I assumed the whole width was scrollable. It's true that macos hides scrollbars by default, but the area is normally delineated in some way

nolanlawson commented 1 year ago

I'll leave this open, even though I'm not sure how to solve it.

easrng commented 1 year ago

I don't think we should forcefully try to always show a scrollbar; we should follow the browser/OS defaults. Sorry it's not obvious in this case, but I can't think of a good solution.

As of right now the scrollbar is forcefully hidden with scrollbar-width: none;