OAuth2: use correct `Content-Type` as specified in RFC

nolanlawson / pinafore

Alternative web client for Mastodon (UNMAINTAINED)

https://pinafore.social

GNU Affero General Public License v3.0

1.02k stars 173 forks source link

OAuth2: use correct `Content-Type` as specified in RFC #2343

Closed vitalyster closed 1 year ago

vitalyster commented 1 year ago

Token request should use application/x-www-form-urlencoded: https://www.rfc-editor.org/rfc/rfc6749#section-4.1.3

nolanlawson commented 1 year ago

Thanks for opening this PR! Could you explain what problem this solves? E.g. is there a fediverse server that is broken with Pinafore's current approach?

vitalyster commented 1 year ago

I'm implementing Mastodon API on my own server and that is the issue I spend hours to find why Pinafore doesn't sign in. It's better to make it use standard behavior to help new developers in the future.