nolanlawson / pokedex.org

Offline-capable Pokédex web site (unmaintained)
https://www.pokedex.org
Apache License 2.0
2.27k stars 324 forks source link

Description for Mew showing as Mewtwo #52

Open djrosenbaum opened 8 years ago

djrosenbaum commented 8 years ago

Pokedex.org description for Mew is showing MewTwo's description.

Description for Mew https://pokeapi.co/api/v1/description/2475/

Description for Mewtwo https://pokeapi.co/api/v1/description/2459/

samccone commented 8 years ago

this is a serious issue

djrosenbaum commented 8 years ago

i see the problem. below data from monsters.txt, some monster descriptions have multiple _gen_5

Affected Pokemon include Pidgeot, Woobat, and Mew.

desc: Pidgeot 2 [ { name: 'pidgeotto_gen_5',
    resource_uri: '/api/v1/description/269/' },
  { name: 'pidgeot_gen_5',
    resource_uri: '/api/v1/description/285/' } ]
desc: Paras 2 [ { name: 'paras_gen_5',
    resource_uri: '/api/v1/description/747/' },
  { name: 'parasect_gen_5',
    resource_uri: '/api/v1/description/764/' } ]
desc: Abra 2 [ { name: 'abra_gen_5',
    resource_uri: '/api/v1/description/1020/' },
  { name: 'kadabra_gen_5',
    resource_uri: '/api/v1/description/1039/' } ]
desc: Porygon 3 [ { name: 'porygon_gen_5',
    resource_uri: '/api/v1/description/2260/' },
  { name: 'porygon2_gen_5',
    resource_uri: '/api/v1/description/3643/' },
  { name: 'porygon-z_gen_5',
    resource_uri: '/api/v1/description/5754/' } ]
desc: Kabuto 2 [ { name: 'kabuto_gen_5',
    resource_uri: '/api/v1/description/2305/' },
  { name: 'kabutops_gen_5',
    resource_uri: '/api/v1/description/2321/' } ]
desc: Mew 2 [ { name: 'mewtwo_gen_5',
    resource_uri: '/api/v1/description/2459/' },
  { name: 'mew_gen_5', resource_uri: '/api/v1/description/2475/' } ]
desc: Marill 2 [ { name: 'marill_gen_5',
    resource_uri: '/api/v1/description/2916/' },
  { name: 'azumarill_gen_5',
    resource_uri: '/api/v1/description/2933/' } ]
desc: Aron 2 [ { name: 'aron_gen_5',
    resource_uri: '/api/v1/description/4379/' },
  { name: 'volcarona_gen_5',
    resource_uri: '/api/v1/description/6436/' } ]
desc: Woobat 2 [ { name: 'swoobat_gen_5',
    resource_uri: '/api/v1/description/5998/' },
  { name: 'woobat_gen_5',
    resource_uri: '/api/v1/description/5993/' } ]
desc: Klink 2 [ { name: 'klink_gen_5',
    resource_uri: '/api/v1/description/6276/' },
  { name: 'klinklang_gen_5',
    resource_uri: '/api/v1/description/6284/' } ]
desc: Klang 2 [ { name: 'klang_gen_5',
    resource_uri: '/api/v1/description/6280/' },
  { name: 'klinklang_gen_5',
    resource_uri: '/api/v1/description/6284/' } ]
nolanlawson commented 8 years ago

Yeah unfortunately the data was taken from pokeapi v1. Migrating to v2 ought to correct the problem, but I've been avoiding it because I basically used a lot of ad-hoc scripts to transform v1 into the format used by the app, and those would need to be almost entirely rewritten for v2...