search

nolanlawson / pokedex.org

Offline-capable Pokédex web site (unmaintained)
https://www.pokedex.org
Apache License 2.0
2.27k stars 325 forks source link

[ISSUE 7, 8] prevents mobile scrolling with fixed detail overlay #59

Closed djrosenbaum closed 7 years ago

djrosenbaum commented 7 years ago

Fixes #7 #8

Prevents scrolling on mobile iOS from Detail View

djrosenbaum commented 7 years ago

This pull request fixes a bug on iphone preventing the background from scrolling in safari when the fixed position detail overlay is displayed.

nolanlawson commented 7 years ago

Thanks, LGTM!

nolanlawson commented 7 years ago

Changes are now live, also @djrosenbaum you are now a collaborator. :) Feel free to push minor changes yourself or @-mention me for big stuff if you still want a review.

nolanlawson commented 7 years ago

FWIW I don't have big plans for Pokedex at this time; I'd like to get scrolling fixed on the main view in iOS but I'm also kinda hoping Safari might fix it themselves. Other than that the next big thing is probably updating to the pokeapi v2 data which is a huge undertaking especially because it probably also necessitates a rewrite of the PouchDB logic to actually allow syncing instead of using pouchdb-load for everything.

tnguyen14 commented 7 years ago

@nolanlawson do you have anything started for the migration to pokeapi v2? wondering if there's something I could help with here.

nolanlawson commented 7 years ago

I've decided to un-maintain this project. The v2 migration would be an enormous amount of work, and I don't have the energy to undertake it. The point of this project was to show what could be done with good performance best practices and emerging PWA technologies.

If someone else would like to undertake the work, please go ahead and fork but I'd prefer to keep pokedex.org as-is at least for the near future. :)