search

nolanlawson / pokedex.org

Offline-capable Pokédex web site (unmaintained)
https://www.pokedex.org
Apache License 2.0
2.27k stars 325 forks source link

monsters-search-bar is missing a label #63

Closed awayken closed 7 years ago

awayken commented 7 years ago

Accessibility recommendation from: https://dequeuniversity.com/rules/axe/1.1/label

I think the MUI floating labels would best complement the existing design. I'll work on submitting a pull request.

nolanlawson commented 7 years ago

Thank you, I didn't realize that using placeholder as a replacement for label would hurt accessibility. Appreciate the PR!