Fixed Directory display issue

nolanlawson / pretty-s3-index-html

A prettier index.html for listing public files and folders in Amazon S3 buckets. (UNMAINTAINED)

114 stars 125 forks source link

Fixed Directory display issue #4

Closed Hayorti closed 8 years ago

Hayorti commented 8 years ago

Modified RegExp for directory/folder detection

nolanlawson commented 8 years ago

Sorry, what is this fixing? I'm looking at the current master version and I don't notice anything really wrong; can you explain what the "directory/folder detection" issue is?

Example: https://nolanlawson.s3.amazonaws.com/index.html

wlngai commented 8 years ago

Hi Nolan,

Very useful tool that you developed here! This was the pull request originated from this issue https://github.com/nolanlawson/pretty-s3-index-html/issues/3. I tested it myself, after this change the folders are displayed probably, otherwise folders are displayed as an empty line instead.

Best Regards, W

nolanlawson commented 8 years ago

This doesn't work correctly on my bucket at least: https://nolanlawson.s3.amazonaws.com/index.html. Directories end up showing up as ..._$folder$.

Maybe different buckets are different? Anyway, I encourage you to fork my repo and maintain your own copy, but I am no longer maintaining this repo because I don't have the time to debug these Amazon issues. Good luck!