Chris Crossover Review Ticket 2/7 for Dylan

[Chris-Ru]

Github Integration into project

To Be Graded

Unit 3(Has User Input)

• Wiki
• Repl.it

Unit 7

• Wiki
• Repl.it

Unit 10(Has User Input)

• Wiki
• Repl.it

Not to be Graded

Unit 5(Has User Input)

• Wiki
• Repl.it

[dylanroman]

Grading:

9 FRQs are under management (90%). - 9/9

• Wiki with talking points/learned concepts
• FRQs under one menu (main file in replit)
• Github integration of faqs

At least 2 FRQs with input and output (10%) - 1/1

• FRQ3 Has User Input
• FRQ5 Has User Input
• FRQ10 Has User Input

Total: 10/10

[dylanroman]

Comparison

FRQ 3:

Weaknesses

• Getters do not require a parameter, however they function properly

Strengths

• Adding user input is done effectively. Scanner does not intrude on the class, it instead creates values that would otherwise be hard coded into the code instead of from user input.

FRQ 7:

Weaknesses

• In the "isUsed" function, an enhanced for loop could have been used instead of a normal for loop.

Strengths

• Checks in constructor searching for any illegal values is better in Chris's code than in mine.

FRQ 10

Weaknesses

• GCF Function would be better if a temporary value was used instead of changing the b value, doing so would allow the two input numbers, and singular output number would be returned easily.

Strengths

• Displays and context for class outputs are integrated within the class instead of in the tester class.
• Catch checking for integers is implemented to ensure there is no margin for user error

[Chris-Ru]

Reflection

Weaknesses

• When creating methods or constructors, don't add extra code that I don't need such a variables and returning variable instead of just returning initialized instance variable(s)
• could simplify iteration statements such as for loops with enhanced for loops

Strengths

• Check for illegal inputs for given variable type for input with try and catch
• code from each frq aren't found within main class, such as input with scanner