nolenroyalty / flappy-dird

An implementation of flappy bird in MacOS's Finder
MIT License
198 stars 10 forks source link

invalid syntax #1

Open piyomaru opened 11 months ago

piyomaru commented 11 months ago

I checked your flap.py from terminal. My environment is macOS 13.6.1 + Mac mini M1. Python version is 3.9.6.

me@m1mini ~ % python /Users/me/Documents/AppleScript\ 13/Games/flappy-bird/flappy-dird-main/flappy_cot.scptd/Contents/Resources/flap.py first-time-setup File "/Users/me/Documents/AppleScript 13/Games/flappy-bird/flappy-dird-main/flappy_cot.scptd/Contents/Resources/flap.py", line 290 match result: ^ SyntaxError: invalid syntax

nolenroyalty commented 11 months ago

Ah! Sorry, the ‘match’ statement in Python is pretty new (on mobile or I’d look up when it came out).

If you change the match to a series of ifs it’ll work. I’ll write a patch when I’m not traveling (or happy to accept a patch here) - the match is not that important and it’d make the code much more version agnostic.

On Sun, Oct 8, 2023 at 11:06 PM Takaaki Naganoya @.***> wrote:

I checked your flap.py from terminal. My environment is macOS 13.6.1 + Mac mini M1. Python version is 3.9.6.

@.*** ~ % python /Users/me/Documents/AppleScript\ 13/Games/flappy-bird/flappy-dird-main/flappy_cot.scptd/Contents/Resources/flap.py first-time-setup File "/Users/maro/Documents/AppleScript 13/Games/flappy-bird/flappy-dird-main/flappy_cot.scptd/Contents/Resources/flap.py", line 290 match result: ^ SyntaxError: invalid syntax

— Reply to this email directly, view it on GitHub https://github.com/nolenroyalty/flappy-dird/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMZIF7HMZM2NS4H6M7F5WDX6KXOVAVCNFSM6AAAAAA5XWY776VHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTCOBRHAZTGMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

nolenroyalty commented 11 months ago

@piyomaru I removed the match statement so I think your version of Python should be happy with it. Can you re-pull the code (and make sure to check the updated instructions - I missed a step earlier!) and try again?

durka commented 11 months ago

I believe the next issue you'll run into is that the applescript doesn't work when there are spaces in the path