search

nolenroyalty / flappy-dird

An implementation of flappy bird in MacOS's Finder
MIT License
200 stars 10 forks source link

Develop/simplify osa script #7

Closed itspluxstahre closed 1 year ago

itspluxstahre commented 1 year ago

Simplification of the applescript and remove templates to make it a bit more robust and use functions in applescript to figure out the path to the pythonscript instead of template. The first-time-setup is still used to create buf1 + buf2 to make it a bit easier to set up the correct viewport before running the applescript.

nolenroyalty commented 1 year ago

Thanks for this!! Just want to note that I’m traveling and it may be a day or three before I am at a laptop and able to review this (especially since it’s in AppleScript!!).

On Wed, Oct 11, 2023 at 1:52 AM Plux Stahre @.***> wrote:

Simplification of the applescript and remove templates to make it a bit more robust and use functions in applescript to figure out the path to the pythonscript instead of template. The first-time-setup is still used to create buf1 + buf2 to make it a bit easier to set up the correct viewport before running the applescript.

You can view, comment on, or merge this pull request online at:

https://github.com/nolenroyalty/flappy-dird/pull/7 Commit Summary

File Changes

(3 files https://github.com/nolenroyalty/flappy-dird/pull/7/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/nolenroyalty/flappy-dird/pull/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMZIF5J6Z33XDVEMGT7OBLX6V4LVAVCNFSM6AAAAAA52VI5GSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTKOBQGIZTANQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

nolenroyalty commented 1 year ago

Thanks again for this! Left a comment for my own benefit as much as anything but I'm gonna go ahead and merge :D