nolimits4web / swiper

Most modern mobile touch slider with hardware accelerated transitions
https://swiperjs.com
MIT License
39.61k stars 9.75k forks source link

swiper.destroy() not working when createElements is enabled #7530

Closed samzabala closed 3 months ago

samzabala commented 4 months ago

Check that this is really a bug

Reproduction link

https://codesandbox.io/p/sandbox/swiper-stupid-38lq4g?file=%2Findex.html

Bug description

swiper.destroy() not working when createElements is enabled. wrapperEl is created dynamically when set to true, but destroy breaks scripts and returns fatal error when this is the setup

Error: 0:4290 Uncaught TypeError: Cannot read properties of undefined (reading 'removeAttribute')

Demo: https://codesandbox.io/p/sandbox/swiper-stupid-38lq4g?file=%2Findex.html

Offending line was found ion the destroy method :

wrapperEl.removeAttribute('style');

could be fixed if there is a condition to check if it exists first

if(wrapperEl) wrapperEl.removeAttribute('style');

please help. thank

Expected Behavior

destroy the slider

Actual Behavior

destroys the site

Swiper version

~11.0.5 - 11.1.1 and 11.1.2 checked

Platform/Target and Browser Versions

Chrome/Edie/Webkit Mac OS

Validations

Would you like to open a PR for this bug?

nolimits4web commented 4 months ago

t0ggles-create swiper

t0ggles[bot] commented 4 months ago

Task nolimits4web/SWIPER-133 was created

t0ggles task SWIPER-133

t0ggles[bot] commented 3 months ago

Task nolimits4web/SWIPER-133 status changed to Done