noloader / cryptopp-cmake

CMake files for Crypto++ project
BSD 3-Clause "New" or "Revised" License
92 stars 67 forks source link

Enable ASM_MASM instead of ASM on MSVC. #20

Closed Nekto89 closed 6 years ago

Nekto89 commented 6 years ago

Without this change rdrand.asm, x64dll.asm and x64masm.asm do not participate in build.

abdes commented 6 years ago

I think there is a bigger issue with handling the special files such as asm files in the build. I'm not comfortable yet with the change you propose in your pull request as you just solved the issue for MSVC. We need a bit more time to review all the changes necessary to properly handle asm compilation.

EDIT 1: Further review of the CMakeLists.txt =>

Changes proposed by @Nekto89 fix the build (which was failing) on appveyor.

==> Suggest to accept his pull request (@noloader )