search

noloader / cryptopp-cmake

CMake files for Crypto++ project
BSD 3-Clause "New" or "Revised" License
92 stars 67 forks source link

Please add -mrdrnd and -mrdseed to rdrand.cpp #21

Closed noloader closed 6 years ago

noloader commented 6 years ago

Uri reported a failure of RDSEED when using CMake. Also see Travis | Job 404134554.

Please add feature tests for RDRAND and RDSEED, and add -mrdrnd and -mrdseed to rdrand.cpp as the features are available. The rdrand.cpp source file is kind of unique in that it may have one or two flags depending on availability.

noloader commented 6 years ago

We may be able to close this with no action based on Commit 1bd18dd5ba62e, Simplify RDRAND and RDSEED logic. The commit removed a lot of complexity but retained the basic case that emitted bytes instead of using the instruction. Emitting the byte codes means we don't need -mrdrnd or mrdseed.

noloader commented 6 years ago

I don't think the problem exists anymore since we simplified the RDRAND and RDSEED logic.