noloader / cryptopp-cmake

CMake files for Crypto++ project
BSD 3-Clause "New" or "Revised" License
92 stars 68 forks source link

Fixes feature detection on Apple platforms #50

Closed netheril96 closed 4 years ago

netheril96 commented 4 years ago

This fixes #41. The builtin try_compile automatically sets the correct isysroot.

noloader commented 4 years ago

Thanks @netheril96.

Forgive me for asking... What problem does this solve?

netheril96 commented 4 years ago

Without this change, CheckCompileLinkOption on macOS always returns failure, even if it should report success. The reason, as have been discussed in #41 , is that CheckCompileLinkOption invokes the CMAKE_CXX_COMPILER directly, but Xcode compiler cannot be invoked directly. try_compile resolves this problem.

netheril96 commented 4 years ago

Hello?

noloader commented 4 years ago

Thanks @netheril96