search

noloader / cryptopp-cmake

CMake files for Crypto++ project
BSD 3-Clause "New" or "Revised" License
92 stars 67 forks source link

Introduce new CMake policies for PR #85 #86

Closed laitingsheng closed 2 years ago

laitingsheng commented 2 years ago

I've added two new CMake policies (CMP0077 and CMP0126) for better integration as a subproject after PR #85.

I've committed an unwanted change in the previous PR (#85), apologies for this:

https://github.com/noloader/cryptopp-cmake/blob/d745d65355dcc1ad4ea67267676d16619ee5fca7/CMakeLists.txt#L116

This will lead to an error during generation, but the original version should be working properly:

https://github.com/noloader/cryptopp-cmake/blob/e5f1db7dee2d7a41ae9e2a516c7e3df9b26bec0e/CMakeLists.txt#L116

I didn't notice this until I clean the CMake cache and re-clone your repository and re-run CMake. Sorry for this.

~Also, this lead me to investigate what happened to your AppVeyor as your AppVeyor has stopped working since last month. As per the official documentation for CMake 3.12, it should be working properly for backward compatibility, but the errors given in AppVeyor logs show that the generation failed with this syntax of platform specification. I've attempted to remove the old specification format to fix the problem.~

I gave up on the attempt to fix AppVeyor since CMake doesn't seem to work well with Visual Studio when building ARM artifacts. It fails to use the correct assembler (ARMASM).

@noloader Anyway, the CMake generation works fine in build 289 ~ 301, only the compilation part by Visual Studio has failed repeatedly.