search

noloader / cryptopp-cmake

CMake files for Crypto++ project
BSD 3-Clause "New" or "Revised" License
92 stars 67 forks source link

Fixed missing `-D` in several compile definitions #87

Closed codeshaunted closed 2 years ago

codeshaunted commented 2 years ago

Several compile definitions in CRYPTOPP_COMPILE_DEFINITIONS weren't prefixed with -D, which caused compilation errors for me on Windows with CMake 2.21. I've gone through and added the prefix to every one I could find.

codeshaunted commented 2 years ago

Any chance someone can look into merging this? My projects won't build on Windows without this change, and I don't want to be using a custom fork for my submodules.

abdes commented 2 years ago

CMake normally adds the -D automatically to compiler definitions: https://cmake.org/cmake/help/latest/prop_sf/COMPILE_DEFINITIONS.html

The COMPILE_DEFINITIONS property may be set to a semicolon-separated list of preprocessor definitions using the syntax VAR or VAR=value.

Your version of cmake is not even supported anymore. Please use a more recent version.

codeshaunted commented 2 years ago

I think that may have been a typo and meant to be 3.21. Will later reopen if that’s the case.

abdes commented 2 years ago

Yes, please check with the current master and if you still have a problem, please reopen and update to the latest master, I will check it again.