search

noloader / cryptopp-pem

PEM parsing of keys and parameters for Crypto++ project
42 stars 31 forks source link

Rename the misleadingly named method GetSubjecPublicKeyAlgorithm. #17

Closed jonathanverner closed 9 months ago

jonathanverner commented 9 months ago

The method name indicated that it would return the algorithm of the public key that is signed by the certificate. Instead it returned the algorithm used to sign the public key. The current commit changes it return the OID of the public key algorithm and adds a new method, GetSubjectSignatureAlgorithm, to retrieve the information that was originally returned --- the signature algorithm.

noloader commented 9 months ago

Thanks @jonathanverner.

jonathanverner commented 9 months ago

Thank you for the library. And thanks for merging!