search

noloader / cryptopp-pem

PEM parsing of keys and parameters for Crypto++ project
42 stars 31 forks source link

Expanding test coverage and adding Makefile #6

Closed alambrec closed 5 years ago

alambrec commented 5 years ago

Hi,

I have finished to expand test coverage and add Makefile.

You can close this pull request if you found that is not necessary ;)

noloader commented 5 years ago

@alambrec,

We're a C++ project. Use CXX and CXXFLAGS; not CC and CFLAGS. I'd fix that.

Does the code wrap https://www.cryptopp.com/wiki/PEM_Pack#Testing_Keys ? If so, then merge it.

alambrec commented 5 years ago

@noloader,

Thanks for your remark about CXX and CXXFLAGS. I fixed that.

About the documentation at https://www.cryptopp.com/wiki/PEM_Pack#Testing_Keys, my changes don't significantly affect it.

However, currently, the expected output of pem-test.exe is not correct within the docs.

We must update this section :

$ ./pem-test.exe
Running 0
Running 1
Running 2
Running 3
Running 4
...
Running 26
Running 27
Running 28
Running 29
Running 30
Running 31
Parsed 153 certificates from cacert.pem
All tests passed

by :

$ ./pem-test.exe
Load RSA public key
Load RSA private key
Load encrypted RSA private key
Load DSA parameters
Load DSA public key
Load DSA private key
Load encrypted DSA private key
Load EC parameters
Load EC public key
Load EC private key
Load encrypted EC private key
Save RSA public key
Save RSA private key
Save encrypted RSA private key
Save DSA parameters
Save DSA public key
Save DSA private key
Save encrypted DSA private key
Save EC parameters
Save EC public key
Save EC private key
Save encrypted EC private key

Also, the Makefile is not documented, because it depends on directory hierarchy in order to find cryptopp source.

I can add some explanations in README.txt if necessary ...

noloader commented 5 years ago

This is a bit dated. Closing.