noloader / rufus

The Reliable USB Formatting Utility
https://rufus.ie
GNU General Public License v3.0
2 stars 0 forks source link

Add SHA-1 and SHA-256 acceleration #1

Open noloader opened 1 year ago

noloader commented 1 year ago

An issue to discuss SHA-1 and SHA-256 acceleration. We can kick around the code for the acceleration in this fork.

If @pbatard is satisfied with the results, then it can be added to RUFUS.

noloader commented 1 year ago

@pbatard,

The initial cut-in is complete. Let me know what you think, please.

I still need to run the code. I have to move a VM to the i7 10th gen machine where I can exercise the SHA instructions.

pbatard commented 1 year ago

Wow, that was fast!

It'll probably be next week before I can review it in earnest, but I like what I'm seeing so far. It's quite a clean breakdown, and my biggest worry concerning the amount of extra code this may entail appears to have been unfounded.

I can definitely see myself integrating what looks like very nice work indeed, into Rufus... 😄

But again, it'll probably be mid next week before I can properly review your proposal. In the meantime you have my thanks for putting up with the constraints of the project, and spending time on this proposal.