nologic / idaref

IDA Pro Instruction Reference Plugin
GNU General Public License v2.0
636 stars 108 forks source link

Fix "Lookup Instruction" #24

Closed erazor-de closed 3 years ago

erazor-de commented 3 years ago

As this porting guide suggests idc.AskStr is replaced with ida_kernwin.ask_str. This patch that fixes the "Lookup Instruction" functionality, tested with IDA 7.5:

diff --git a/idaref.py b/idaref.py
index e9445f1..18008d1 100755
--- a/idaref.py
+++ b/idaref.py
@@ -5,7 +5,7 @@ import inspect
 import glob
 import idaapi
 from idc import print_insn_mnem, get_screen_ea
-from ida_kernwin import ask_long, find_widget, close_widget
+from ida_kernwin import ask_long, find_widget, close_widget, ask_str

 initialized = False
@@ -340,7 +340,7 @@ class InstructionReference(idaapi.simplecustviewer_t):
         if menu_id == self.menu_update:
             self.update(True)
         elif menu_id == self.menu_lookup:
-            inst = AskStr(self.last_inst, "Instruction: ")
+            inst = ask_str(self.last_inst, 0, "Instruction: ")
             if inst != None:
                 self.load_inst(inst, True)
         elif menu_id == self.menu_autorefresh:
erazor-de commented 3 years ago

I made a pull request of this and more...