search

nomad-cli / houston

Apple Push Notifications; No Dirigible Required
http://nomad-cli.com
MIT License
2.93k stars 229 forks source link

Aa 139 #150

Closed andrewarrow closed 6 years ago

andrewarrow commented 7 years ago

for https://github.com/nomad/houston/issues/139

working with these env vars

export APN_PRIVATE_KEY=/Users/aa/dev/houston/APNsAuthKey_ABCDE12345.p8 
export APN_TEAM_ID=YOURTEAMID
export APN_KEY_ID=ABCDE12345
export APN_TOPIC=com.bundle.id
JanC commented 7 years ago

what is currently missing in the implementation to accept this PR?

andrewarrow commented 7 years ago

I made a new gem here with just the p8 format https://github.com/andrewarrow/p8push

this PR needs some work to make the p8 format work side by side with pem format.

JanC commented 7 years ago

alright, thanks

RamblinWreck77 commented 5 years ago

Any reason this didn't get merged? It seems like .p8 is way better, having to refresh certs yearly is a PITA.

andrewarrow commented 5 years ago

Right on @RamblinWreck77 no reason not to merge IMO. Well, unless you want it to work with both old format and new.

RamblinWreck77 commented 5 years ago

@dankimio Any elaboration on why this was closed? Would really like this feature

kristophM commented 5 years ago

Curious why this was closed? p8 seems far superior

andrewarrow commented 5 years ago

I think the issue is OG houston without p8 has tons of logic in it for the old system and it’s hard to make houston code base compatible for both options. Perhaps a new fork of houston called something like houston-p8 with support only for p8 format is what is needed?