search

nomad-cli / houston

Apple Push Notifications; No Dirigible Required
http://nomad-cli.com
MIT License
2.93k stars 229 forks source link

Only non-empty passphrase when creating key #154

Closed groomsy closed 7 years ago

groomsy commented 7 years ago

We should only pass non-empty passphrases when creating a key. If we don't avoid empty passphrases, certificates without passphrases will throw an error when attempting to create the key.

groomsy commented 7 years ago

I came across this annoyance with a development certificate. Basically, I didn't put a passphrase on the certificate since I was just using it for testing locally. Since I didn't have a passphrase, I didn't include it in my push call from CLI (and I didn't have the environment variable set). This gave me an error. I could literally give the command any passphrase and it would accept it. So we should just avoid sending a passphrase if it's empty.