nomad-cli / houston

Apple Push Notifications; No Dirigible Required

http://nomad-cli.com

MIT License

2.93k stars 229 forks source link

Update notification.rb #169

Closed ab320012 closed 3 years ago

ab320012 commented 5 years ago

168 opening pr as i need the header in one of the apps i support

dankimio commented 5 years ago

Can you link the corresponding documentation?

ab320012 commented 5 years ago

@dankimio yes, to be honest i don't think this PR actually modifies the header i am sort of confused as to how to encode that header with whats currently there do you mind helping?

https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns

dankimio commented 5 years ago

@ab320012 Headers are a bit different from the payload. It's something that we haven't implemented yet.

ab320012 commented 5 years ago

@dankimio yes i am aware wondering how i can get it done or if you are going to do add the header as it will break houston for ios13 which is already out

nightpool commented 4 years ago

It looks like Houston currently uses the legacy, binary notification format instead of the HTTP/2 api. Apple so far has not provided any documentation on how to supply this parameter with the legacy notification, or if one is even required. Has someone been able to test that pushes through Houston are actually rejected from an iOS 13 device, or are we just going off of possibly inaccurate documentation?

khiav223577 commented 4 years ago

@dankimio yes, to be honest i don't think this PR actually modifies the header i am sort of confused as to how to encode that header with whats currently there do you mind helping?

https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns

The documentation seems to have been modified.