search

nomad-cli / houston

Apple Push Notifications; No Dirigible Required
http://nomad-cli.com
MIT License
2.93k stars 229 forks source link

Adding the ability pass in options to Houston::Client.new #60

Closed rickychilcott closed 10 years ago

rickychilcott commented 10 years ago

We have a need to be able to initialize a Houston::Client with specific options and would like the ability to pass options in. Currently, it only allows you to rely on ENV variables.

This commit does not break that existing functionality.

rickychilcott commented 10 years ago

Hey @mattt Do you think this is a good addition?

mattt commented 10 years ago

@rickychilcott Not especially. Specific configuration should be done with environment variables, so init arguments are not a pattern I'd wish to advocate. If you really need this kind of customization, attributes can be accessed directly after creation.

rickychilcott commented 10 years ago

Thanks for reviewing @mattt I'm familiar with 12factor and try to use it where possible. Since we're using Houston::Client as a library and less as a cli tool, I figured we'd try. I'll end up creating a client and then changing attributes after init. Thanks for looking and giving feedback.