search

nomad-cli / houston

Apple Push Notifications; No Dirigible Required
http://nomad-cli.com
MIT License
2.93k stars 229 forks source link

Invalid Maximum Payload Size #74

Closed jievans closed 10 years ago

jievans commented 10 years ago

Is the Houston::Notification::APNSError::MAXIMUM_PAYLOAD_SIZE of 2048 bytes invalid?

According to this issue, in production the maximum payload size APNS will accept is still 256 bytes.

mattt commented 10 years ago

Is the Houston::Notification::APNSError::MAXIMUM_PAYLOAD_SIZE of 2048 bytes invalid?

No, this is correct. The referenced issue explains this pretty clearly.

jievans commented 10 years ago

@mattt Maybe I missed something in reading through the referenced issue, but if the max payload size is still 256 bytes in production, what was the rationale for increasing the payload size to 2048 within Houston?If an implementation relied on Houston's validations for checking payload length in production, that implementation would be broken by the bump of MAXIMUM_PAYLOAD_SIZE to 2048.

Thanks so much for your time!