Shenzen fails on Xcode version check when evaluating Xcode 10+

nomad-cli / shenzhen

CLI for Building & Distributing iOS Apps (.ipa Files)

MIT License

4.65k stars 492 forks source link

Shenzen fails on Xcode version check when evaluating Xcode 10+ #351

Closed thzinc closed 5 years ago

thzinc commented 5 years ago

The command to evaluate the current Xcode version is doing a string comparison on the Xcode version number against the string "4.0.0". This fails for Xcode 10+ because the version number "10.0.0" is evaluated as less than "4.0.0".

thzinc commented 5 years ago

I'll submit a PR for this issue shortly.

dankimio commented 5 years ago

Fixed in #352