search

nomad-coe / electronic-parsers

Apache License 2.0
18 stars 7 forks source link

FHI-aims testing error #145

Closed JosePizarro3 closed 10 months ago

JosePizarro3 commented 11 months ago

@ladinesa @ndaelman-hu I am trying to run locally the tests (using python -m pytest -sv tests) and it seems that FHI-aims has an error. Here is the message I got:

============================================================================================================================== ERRORS ==============================================================================================================================
___________________________________________________________________________________________ ERROR collecting dependencies/parsers/electronic/tests/test_fhiaimsparser.py ___________________________________________________________________________________________
Fixture "silicon_versions" called directly. Fixtures are not meant to be called directly,
but are created automatically when test functions request them as parameters.
See https://docs.pytest.org/en/latest/fixture.html for more information about fixtures, and
https://docs.pytest.org/en/latest/deprecations.html#calling-fixtures-directly about how to update your code.
===================================================================================================================== short test summary info ======================================================================================================================
ERROR tests/test_fhiaimsparser.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Can any of you take a look on this 🙂? Pylens is getting crazy so I am not sure who did these changes.

ladinesa commented 10 months ago

silicon_versions should simply be a tuple and parse_native_tiers should not be a fixture. Also looking at the test data, they are quite big. please consider replacing these with smaller ones, if possible use existing test set.

JosePizarro3 commented 10 months ago

Hi @ndaelman-hu , can you please take a look into this? I add to @ladinesa's comment that the test_native_tiers is super-heavy, it froze my computer.

ndaelman-hu commented 10 months ago

I'm rewriting native_tiers. I'll take this in consideration.

ndaelman-hu commented 10 months ago

Fixed the tests (except test_native_tier), ready to merge. Note that these tests were implemented over 10 months ago, so I'm unsure what broke there. Maybe a pytest update?