nomad-coe / electronic-parsers

Apache License 2.0
18 stars 7 forks source link

148 handle changing symmetries in vasp #150

Open ndaelman-hu opened 11 months ago

ndaelman-hu commented 11 months ago

Tackle changing symmetries (and k-point set) between ionic updates in newer VASP versions (about 6). This solution packages kpoints into lists matching the no. calculations. The cases of single-point calculations and the older format are also handled (for vasprun.xml). No explicit information about the version is used.

Closes #148

ndaelman-hu commented 11 months ago

@ladinesa Should I add the test referenced in the original issue?

ladinesa commented 11 months ago

Thanks for the fix. Please also add a test for this, maybe one outcar and one vasprun, you can also use this for the atom positions fix.

ndaelman-hu commented 10 months ago

Something to consider in the future, when we clean the VASP parser. The VASP mainfiles have very different structures. Just considering the case of the frequency analysis:

When it comes to eigenvalues, we mostly just need the no. irreducible k-points (at that step) to restructure the eigenvalues. Atm, we are extracting all the k-points in full, at each step, and this might be overkill. Full extraction is only needed at the last step.