search

nomad-coe / electronic-parsers

Apache License 2.0
18 stars 7 forks source link

Fix solid dmft #164

Closed JosePizarro3 closed 9 months ago

JosePizarro3 commented 10 months ago

Fixing the solid_dmft parser, and taking away things that made the archive very heavy.

Now parsing also supports real frequencies and DOS parsing.

JosePizarro3 commented 10 months ago

Hi @ladinesa these are some changes on the solid_dmft parser. An user pointed out some bugs, and I took this chance to improve on the parser, moving heavy stuff to JSON types and HDF5Reference.

I tested it in several examples and it seems to be working nicely. But feel free to suggest changes please 🙂

JosePizarro3 commented 10 months ago

Thanks a lot for the review. I had to also fix some GW parsing, as now FrequencyMesh is a repeated quantity.

Let me know what you think.

JosePizarro3 commented 9 months ago

If approved, I can merge this and contact the developer back. Thanks for the review, @ladinesa 🙂