search

nomad-coe / nomad-schema-plugin-example

This is an example for NOMAD schema plugins. It should be forked to create actual plugins.
Apache License 2.0
13 stars 16 forks source link

nomad_plugin.yaml is missing in pip installed package #11

Open markus1978 opened 3 months ago

markus1978 commented 3 months ago

When you pip install, e.g.:

pip install git+https://github.com/nomad-coe/nomad-schema-plugin-example@main

The nomadschemaexample/nomad_plugin.yaml is not copied to the install folder (e.g. ...python3.9/site-packages/nomadschemaexample/). Without the file the plugin cannot be used.

@schumannj has this problem in her fork too: https://github.com/schumannj/nomad-schema-plugin-fhi-catalysis

For some reason it works for other projects (e.g. https://github.com/FAIRmat-NFDI/nomad-measurements) it works fine. Weirdly enough, the seemingly relevant parts of the respective pyproject.tomls look the same.

markus1978 commented 3 months ago

@blueraft please have a look as soon as you can. This is currently failing our example oasis deployment, because it includes @schumannj 's plugin.

If you have a solution, please also open a PR for https://github.com/schumannj/nomad-schema-plugin-fhi-catalysis.

markus1978 commented 3 months ago

@lauri-codes this is the cause for the example oasis deployment failing.

markus1978 commented 3 months ago

@hampusnasstrom Maybe you know more? For your measurments and materials processing plugins the nomad_plugin.yaml gets installed properly.

blueraft commented 3 months ago

I've created a PR for this in this repo. Once it gets merged, I can create a PR in fhi-catalysis repo.

hampusnasstrom commented 3 months ago

Seems like Ahmed solved this? But I did have some issues with this for installing a plugin that's not at the top level of a github repository. However, adding a MANIFEST.in solved this so I usually add one now with the line:

recursive-include * nomad_plugin.yaml