Closed JosePizarro3 closed 5 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
tests/conftest.py | 24 | 25 | 96.0% | ||
<!-- | Total: | 113 | 114 | 99.12% | --> |
Totals | |
---|---|
Change from base Build 9191394544: | 0.3% |
Covered Lines: | 717 |
Relevant Lines: | 728 |
Hey @ndaelman-hu there seems to be something off with the resolve_points_and_offset
method in KMesh
. I think for 'Gamma-centered'
, the points returned are some weird list. Can you check it? I will push some testing for KMesh
and this specific method so you see what is happening.
Ok, @ndaelman-hu this is ready for another review. I added a functionality to extract KMesh.high_symmetry_points
from the legacy normalizers
Ok, this is ready. I decided to group the _check_reciprocal_lattice_vectors
and resolve_high_symmetry_points
methods into a functionality class, as these are being used for both KMesh
and KLinePath
. I think this is nice, let me know what you think.
I'd like to merge this today.
@ndaelman-hu I would need a quick review on this to be able to keep working on #52